Make WindowedValue a public interface - #35159
Conversation
github-actions
Bot
added
java
io
extensions
runners
spark
dataflow
direct
gcp
core
flink
fn-execution
jet
local
samza
euphoria
twister2
labels
|
R: @ahmedabu98 or @stankiewicz If you wouldn't mind just scrolling through and convincing yourself I didn't make any nontrivial change. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
8560e4c to
7904ba3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35159 +/- ##
=========================================
Coverage 56.44% 56.44%
- Complexity 3299 3300 +1
=========================================
Files 1185 1185
Lines 181910 181915 +5
Branches 3409 3409
=========================================
+ Hits 102682 102689 +7
+ Misses 75959 75958 -1
+ Partials 3269 3268 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stankiewicz
left a comment
stankiewicz
left a comment
There was a problem hiding this comment.
I've reviewed sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValue.java
and sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValues.java
and skimmed through most of the small changes. .
7904ba3 to
05dcac2
Compare
|
Thanks! Fixing up some reflective access in the SparkRunner before I merge. |
The following mostly-automated changes: - Moved WindowedValue from util to values package - Make WindowedValue an interface with companion class WindowedValues
05dcac2 to
94d3261
Compare
ab77aea to
479f0d6
Compare
|
Dataflow Streaming |
3 participants
The following mostly-automated changes:
WindowedValuefrom internal-onlyutilto publicvaluespackageWindowedValuean interface with companion classWindowedValuesThis is an initial step to #34902 that touches lots of lines and files but is largely automated and has no interesting content. Separating this for ease of review.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.